Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solves iOS playback problems #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Solves iOS playback problems #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee54267
Updated XCDYouTubeKit version
christopherafbjur Mar 3, 2020
6c6d024
Update version
christopherafbjur Mar 3, 2020
5910f1b
Replaced youtube url with youtube-nocookie
christopherafbjur Nov 9, 2020
0a91e0f
Update XCDYoutubeKit 2.12 -> 2.15.2
christopherafbjur Jun 14, 2021
36369af
Correction, version bump of plugins.xml aswell
christopherafbjur Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-youtube-video-player",
"version": "2.4.0",
"version": "2.4.2",
"description": "**Play Youtube Videos in a native Video Player on Android & iOS.**",
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion platforms/android/src/com/bunkerpalace/cordova/YoutubeVideoPlayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ private Intent createYoutubeIntent(String videoId) {
if(YouTubeIntents.canResolvePlayVideoIntentWithOptions(cordovaContext)){
intent = YouTubeIntents.createPlayVideoIntentWithOptions(cordovaContext, videoId, true, true);
} else {
intent = new Intent(Intent.ACTION_VIEW, Uri.parse("http://www.youtube.com/watch?v=" + videoId), cordovaContext, YouTubeActivity.class);
intent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://www.youtube-nocookie.com/embed/" + videoId), cordovaContext, YouTubeActivity.class);
intent.putExtra("videoId", videoId);
ConfigXmlParser parser = new ConfigXmlParser();
parser.parse(cordovaContext);
Expand Down
4 changes: 2 additions & 2 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>

<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0" id="cordova-plugin-youtube-video-player" version="2.4.0">
<plugin xmlns="http://cordova.apache.org/ns/plugins/1.0" id="cordova-plugin-youtube-video-player" version="2.4.2">

<name>CordovaYoutubeVideoPlayer</name>

Expand Down Expand Up @@ -57,7 +57,7 @@
</config-file>


<framework src="XCDYouTubeKit" type="podspec" spec="~> 2.7" />
<framework src="XCDYouTubeKit" type="podspec" spec="~> 2.15.2" />
<header-file src="platforms/ios/YoutubeVideoPlayerProject/Plugins/com.bunkerpalace.cordova.YoutubeVideoPlayer/YoutubeVideoPlayer.h"/>
<source-file src="platforms/ios/YoutubeVideoPlayerProject/Plugins/com.bunkerpalace.cordova.YoutubeVideoPlayer/YoutubeVideoPlayer.m"/>

Expand Down