Allow delayed execution of deallocation operations by waiting engine idle phase #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski
changed the title
igorski
commented
Jan 13, 2024
| @@ -35,7 +35,8 @@ class BaseAudioEvent | |||
| BaseAudioEvent(); | |||
| virtual ~BaseAudioEvent(); | |||
|
|
|||
| void dispose(); // invoke when removing the Event from the engine | |||
| void dispose(); // invoke when removing the Event from the engine, should be done when ENGINE_IDLE is broadcast! | |||
There was a problem hiding this comment.
or when Sequencer isn't running
igorski
commented
Jan 13, 2024
| @@ -465,7 +489,18 @@ public static void handleBridgeConnected( int aSomething ) { | |||
| } | |||
|
|
|||
| public static void handleNotification( int aNotificationId ) { | |||
| if ( INSTANCE != null && INSTANCE._observer != null ) INSTANCE._observer.handleNotification( aNotificationId ); | |||
| if ( INSTANCE != null ) { | |||
| if ( ENGINE_IDLE_NOTIFICATION == aNotificationId && !INSTANCE._idleCallbacks.isEmpty() ) { | |||
There was a problem hiding this comment.
empty check us unnecessary as we can iterate safely over an empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To debug #179