Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF-2921: Do not acquire mutex on unused StreamManager #2636

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Dec 17, 2024

Historically, disabling the Stream Management functionality has been a work-around for various issues.

To be able to work around a deadlock issue as described in OF-2921, this commit prevents a Stream Management-related mutex to be acquired when the Stream Management feature is disabled.

Historically, disabling the Stream Management functionality has been a work-around for various issues.

To be able to work around a deadlock issue as described in OF-2921, this commit prevents a Stream Management-related mutex to be acquired when the Stream Management feature is disabled.
@guusdk guusdk requested review from dwd and Fishbowler December 17, 2024 15:45
Copy link
Member

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe and obvious.

@guusdk guusdk merged commit d5fe627 into igniterealtime:main Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants