Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Spanish Configuration #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CodingAleCR
Copy link

Hi, this is the secondary PR for the Spanish Translation contribution. God Bless you!

@igneus
Copy link
Owner

igneus commented Aug 8, 2018

Thank you very much. Here I will ask for patience - the PR will be merged once the next calendarium-romanum release with the data file contributed by you is released.

@CodingAleCR
Copy link
Author

It's OK, I don't really mind about that. If you need any other help just let me know.

@igneus
Copy link
Owner

igneus commented Aug 8, 2018

Cool, thanks.

I don't need help, but if you (or anyone else reading this) were looking for further opportunities to contribute either to the calendarium-romanum gem or to the API app, don't hesitate to ping me - I usually have around some issues worth working on and would be happy to write them out.

@CodingAleCR
Copy link
Author

Sure, I might not be an excellent Ruby developer, but I can help you out with small issues or stuff... I sent you an email as well.

@igneus
Copy link
Owner

igneus commented Aug 20, 2018

Thank you very much. I have read your e-mail and planned to prepare the issues-worth-working-on first and answer the e-mail subsequently, but that plan was somewhat unrealistic as for my ability to get to it in reasonable time. For now I can only ask for one more bit patience. I will write back as soon as there is something ready, hopefully this week.

@igneus
Copy link
Owner

igneus commented Aug 21, 2018

Over at calendarium-romanum there are finally a few first issues from my private todo-list, I will continue adding more. Later I will get also to tasks related to this app.

I'm no master of either the art of explaining things or the English language, so please don't hesitate to ask questions if some of the issues are hard to comprehend.

@@ -1,5 +1,5 @@
# please update with your own information
---
contact:
name: Example Joe
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I guess you pushed the commit adding this particular change to this PR only by accident. It makes perfect sense for your own installation of the API, but it won't be merged in the main church-calendar-api repo. (I am still grateful for the code in the first commit and will definitely merge and deploy it once I get to this task.)

@igneus igneus mentioned this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants