Move dependencies to calendarium-romanum.gemspec #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm trying to set up a development environment for calendarium-romanum and manage my gem dependencies with [Bundler](https://bundler.io/). So, I'd like to be able to do something like `bundle install --path vendor/bundle` followed by `bundle exec calendariumrom`. Currently, this doesn't work because even after running `bundle install`, it does not know about the `calendarium-romanum` gem itself. In looking for the solution to this, I found [this page](https://bundler.io/v2.0/guides/creating_gem.html) in the Bundler docs. It notes that the `Gemfile`: > contains a gemspec line meaning that Bundler will include dependencies > specified in foodie.gemspec too. It’s best practice to specify all the > gems that our library depends on in the gemspec. Additionally, > Bundler detects our gem, loads the gemspec and bundles our gem just > like every other gem. So, I've added a `gemspec` line to `Gemfile`. Then, I moved dependencies to `calendarium-romanum.gemspec`. **Before:** ``` $ bundle install --path vendor/bundle Bundle complete! 9 Gemfile dependencies, 33 gems now installed. Bundled gems are installed into `./vendor/bundle` $ bundle exec calendariumrom bundler: command not found: calendariumrom Install missing gem executables with `bundle install` ``` **After:** ``` $ bundle install --path vendor/bundle Using calendarium-romanum 0.5.0 from source at `.` Bundle complete! 7 Gemfile dependencies, 34 gems now installed. Bundled gems are installed into `./vendor/bundle` $ bundle exec calendariumrom Commands: ... ``` Supporting this workflow should make it easier for other developers to run the gem after building it themselves, which should make it easier to test, develop, and contribute.
|
Let me know what you think about this - happy to consider other options if you're not a fan of this solution! |
|
This will take me some time to digest - I don't know yet how much I am/am not a fan of this. Will have to read a bit on both Rubygems and Bundler. As for development setup for testing the executable, I haven't tested it much recently, but when I do, I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to set up a development environment for calendarium-romanum
and manage my gem dependencies with Bundler. So,
I'd like to be able to do something like
bundle install --path vendor/bundlefollowed bybundle exec calendariumrom. Currently, thisdoesn't work because even after running
bundle install, it does notknow about the
calendarium-romanumgem itself.In looking for the solution to this, I found this
page in the Bundler
docs. It notes that the
Gemfile:Additionally,
So, I've added a
gemspecline toGemfile. Then, I moved dependenciesto
calendarium-romanum.gemspec.Before:
After:
Supporting this workflow should make it easier for other developers to
run the gem after building it themselves, which should make it easier to
test, develop, and contribute.