Added concurrency flag to helm deploy config

Signed-off-by: Suleiman Dibirov <[email protected]>
idsulik · Sep 6, 2024 · 6900709 · 6900709
1 parent 842e94c
commit 6900709
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/pkg/skaffold/deploy/helm/helm.go b/pkg/skaffold/deploy/helm/helm.go
@@ -263,6 +263,7 @@ func (h *Deployer) Deploy(ctx context.Context, out io.Writer, builds []graph.Art
 	nsMap := map[string]struct{}{}
 	manifests := manifest.ManifestList{}
 	g, ctx := errgroup.WithContext(ctx)
+	g.SetLimit(*h.Concurrency)
 	var mu sync2.Mutex
 
 	// Deploy every release

diff --git a/pkg/skaffold/schema/defaults/defaults.go b/pkg/skaffold/schema/defaults/defaults.go
@@ -46,6 +46,7 @@ func Set(c *latest.SkaffoldConfig) error {
 	defaultToLocalBuild(c)
 	setDefaultTagger(c)
 	setDefaultLogsConfig(c)
+	setHelmDefaults(c)
 
 	for _, a := range c.Build.Artifacts {
 		setDefaultWorkspace(a)
@@ -113,6 +114,17 @@ func Set(c *latest.SkaffoldConfig) error {
 	return nil
 }
 
+func setHelmDefaults(c *latest.SkaffoldConfig) {
+	if c.Deploy.LegacyHelmDeploy == nil {
+		return
+	}
+
+	if c.Deploy.LegacyHelmDeploy.Concurrency == nil {
+		defaultConcurrency := 1
+		c.Deploy.LegacyHelmDeploy.Concurrency = &defaultConcurrency
+	}
+}
+
 // SetDefaultRenderer sets the default manifests to rawYaml.
 func SetDefaultRenderer(c *latest.SkaffoldConfig) {
 	if len(c.Render.Generate.Kpt) > 0 {

diff --git a/pkg/skaffold/schema/latest/config.go b/pkg/skaffold/schema/latest/config.go
@@ -961,6 +961,10 @@ type KubectlFlags struct {
 
 // LegacyHelmDeploy *beta* uses the `helm` CLI to apply the charts to the cluster.
 type LegacyHelmDeploy struct {
+	// Concurrency is how many packages can be installed concurrently. 0 means "no-limit".
+	// Defaults to `1`.
+	Concurrency *int `yaml:"concurrency,omitempty"`
+
 	// Releases is a list of Helm releases.
 	Releases []HelmRelease `yaml:"releases,omitempty"`