Workshop2024 merge #2328
Workshop2024 merge #2328
Conversation
wangcj05
assigned mandd, PaulTalbot-INL, wangcj05, Jimmy-INL, yoshiurr-INL, JunyungKim and joshua-cogliati-inl
|
@joshua-cogliati-inl It seems there is some problem with IDW rom: Do you have time to take a look at it? You can check test at: 
|
Hm, I wonder if commenting out line 234 in @j-bryan or @mandd (Any ideas?) It looks like the Constructors in src/utilities/inverseDistanceWeigthing.cxx do not have any allocation, so I am not sure why a destructor would be needed. |
|
@joshua-cogliati-inl I tried commenting out that line, rebuilding RAVEN, and running the test, and I still got that warning. |
* Removing specifying liblapack. * Switching to setuptools 69. * Adding comment explaining setuptools version. * Adding back windows lapack dependency to see if needed.
…ers (#2319) * moved samplers-optimizers function tests in their own folder for clarity * renamed * modified test names and revisions * moved subfolders * Closes #2302 * usage base class function evaluation method in ensembleForward * added error msg for detection of loop in function system * added test for ensemble model passing strings (restart file paths) around * removed trailing spaces * Update ravenframework/Samplers/EnsembleForward.py * Update ravenframework/Samplers/Sampler.py * Update ravenframework/Samplers/Sampler.py * Update ravenframework/Samplers/Sampler.py * fixed comment * we always check for isolated functions * updated model.tex * changed order to reflect order of appearance in the introduction of the Model sections * modified test description to make them latex compatible * specialization for EnsembleForward and CustomSampler * Apply suggestions from code review addressed Congjian's comments * Apply suggestions from code review * Apply suggestions from code review * Update ravenframework/Samplers/Sampler.py * updated setuptools dep * updated to simply ver 69 * added utility function as Congjian's request * plot entity * model order * added starting models * Apply suggestions from code review * Update ravenframework/utils/graphStructure.py --------- Co-authored-by: Congjian Wang - INL <[email protected]>
* added custom arbitrary input extention to inputspecs and unit test * removing internalParallel for adaptsobol cluster test
* Update FARM user manual and citation * Remove space. * Revert previous. --------- Co-authored-by: Joshua J. Cogliati <[email protected]>
There was a problem hiding this comment.
This pull request adds workshop materials, but it also makes changes in ravenframework (especially in Samplers). It also does a submodule update. However, these are not explained in the Pull Request Description or in the linked Issue/Task.
The workshop additions and the workshop example additions look fine (tho' some of the powerpoint files are on the big side).
UPDATE: The extra changes shown were just a bug in github and was fixed by merging with devel.
|
@joshua-cogliati-inl FYI, I have reduced the sizes of slides based on your suggestion using |
|
This PR only touches workshop materials, and there is no source code updates in this PR. Since HPC is under maintenance, the Test qsubs sawtooth can be skipped in this PR. Once other tests are green, this PR can be merged. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
close #2339
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.