New rep congjian #2058

Jimmy-INL · 2023-02-07T00:06:10Z

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1650 and #1546
This PR will add a representativity calculations post-processor. This post-processor can be used to calculation similarities between prototype and full scale models/experiments, perform input data adjustment, and uncertainty reductions for full scale models/experiments.

Future development will enable this post-processor to accept probability weight coming from other Samplers, such as grid/LHS. See #2196

What are the significant changes in functionality due to this change request?

Implements the representativity theory through bias factors for validation purposes

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

1. Review all computer code.
2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
8. If an analytic test is changed/added is the the analytic documentation updated/added?
9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Jimmy-INL · 2023-09-28T17:39:34Z

ravenframework/Models/PostProcessors/Validations/Representativity.py

+    """
+    # Compute adjusted target #eq 71
+    UtarTilde = normalizedSenTar @ UparVar @ normalizedSenExp.T @ np.linalg.pinv(normalizedSenExp @ UparVar @ normalizedSenTar.T + UmesVar) @ Umes
+    # back transform to parameters


This equation might have a bug. doesn't match equation 71 in the writeup

…Rep-Congjian

mandd

minor comments

mandd · 2023-10-13T14:47:21Z

doc/user_manual/raven_user_manual.bib

+
+@article{Epiney1,
+	title={A Systematic Approach to Inform Experiment Design Through Modern Modeling and Simulation Methods},
+	author={Epiney, A and Rabiti, C and Davis, C},


this reference does not indicate if it is a journal of conf proceeding

mandd · 2023-10-13T14:54:49Z

ravenframework/Models/PostProcessors/Validations/Representativity.py

+      @ In, None
+      @ Out, stat, object, Basic Statistic PostProcessor Object
+    """
+    from .. import factory as ppFactory # delay import to allow definition


should this import be moved to the beginning of the file?

I just reverted the change. It can not moved to the beginning of the file since the class has not been initialized yet. We need to first initialize the PP class then we can import the factory.

mandd · 2023-10-13T14:58:36Z

ravenframework/Models/PostProcessors/Validations/Representativity.py

+          sensMatr[i, j] = sensDict[senName][0]* datasets[inpVar].meanValue / datasets[outVar].meanValue
+    return sensMatr
+
+  def _computeMoments(self, datasets, features, targets):


do we have something already developed that does the same functionality?

We do have similar functions inside Basic Statistics PP. However, it seems there is a more general issue in the developed post-processor. The probability weight is not considered in some functions. For example, the _computeMoments function. I will open an issue for this to allow this PP to accept probability weight in general.

see issue #2196

wangcj05 · 2023-10-17T17:36:02Z

@joshua-cogliati-inl It seems there is another issue with windows installation:

Could not solve for environment specs

The following packages are incompatible

├─ python 3.8**  is requested and can be installed;

└─ truststore is not installable because there are no viable options

   ├─ truststore [0.7.0|0.8.0] would require

   │  └─ python >=3.10  but there are no viable options

   │     ├─ python [3.11.0|3.11.1|...|3.11.6] conflicts with any installable versions previously reported;

   │     ├─ python [3.10.0|3.10.1|...|3.10.9] conflicts with any installable versions previously reported;

   │     ├─ python 3.12.0 conflicts with any installable versions previously reported;

   │     └─ python 3.12.0rc3 would require

   │        └─ _python_rc, which does not exist (perhaps a missing channel);

   ├─ truststore 0.8.0 would require

   │  └─ python >=3.10,<3.11.0a0 , which conflicts with any installable versions previously reported;

   └─ truststore 0.8.0 would require

      └─ python >=3.11,<3.12.0a0 , which conflicts with any installable versions previously reported.


ERROR: exiting with code 1

moosebuild · 2023-10-17T17:43:52Z

Job Mingw Test on 645644e : invalidated by @wangcj05

issue with installation, truststore is not installable because there are no viable options

…Rep-Congjian

moosebuild · 2023-11-06T04:12:44Z

Job Test qsubs sawtooth on 645644e : invalidated by @wangcj05

moosebuild · 2023-11-06T04:13:03Z

Job Mingw Test on 645644e : invalidated by @wangcj05

moosebuild · 2023-11-06T04:33:46Z

Job Test qsubs sawtooth on 645644e : invalidated by @wangcj05

… modifying the input dataset

moosebuild · 2023-11-06T15:24:45Z

Job Test qsubs sawtooth on 6d7d77b : invalidated by @joshua-cogliati-inl

failed in set python environment

moosebuild · 2023-11-06T22:48:17Z

Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05

wangcj05 · 2023-11-07T01:09:07Z

@mandd FYI, the tests are green for this PR. Please let me know if you have additional comments.

moosebuild · 2024-01-03T22:35:53Z

All jobs on 548f9f7 : invalidated by @wangcj05

retesting

wangcj05 · 2024-01-03T22:37:33Z

Hi @mandd, I think this PR is ready for you to take another review. Could you take a look in the next two weeks?

moosebuild · 2024-01-04T15:35:55Z

Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05

directory exists issue

moosebuild · 2024-01-04T19:33:39Z

Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05

environment issue

moosebuild · 2024-01-22T18:19:01Z

Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05

moosebuild · 2024-02-29T15:47:22Z

All jobs on 548f9f7 : invalidated by @wangcj05

retesting

moosebuild · 2024-03-04T18:26:43Z

Job Test qsubs sawtooth on 548f9f7 : invalidated by @wangcj05

Diff tests/cluster_tests/test_mpiqsub_nosplit, not related to this PR

wangcj05 · 2024-03-11T15:46:59Z

@mandd @PaulTalbot-INL @dylanjm @yoshiurr-INL @GabrielSoto-INL Can any of you review this PR? Both Josh and I have contributions to this PR.

moosebuild added 30 commits September 27, 2017 12:01

Merge commit '2a1e5ea5c97250c19da52e7fde4c3dd2fa5fb045'

66ce9db

Merge commit '957bb81bd5d0e2b066b29a317c74646cef4f095f'

60c2698

Merge commit '9e05035ff87fbceddca890b184f65678787fffc2'

4e41935

Merge commit '6755780df1a6fddaad6f4d4ec9040efc5f0b8069'

eaacebf

Merge commit 'd317572ffb80f564d27ec54e5db24d763705a8a5'

91dc79f

Merge commit '5c0409d9e0ccffa34d663f363da358658318d3c4'

06e8d9e

Merge commit '84d21ee902edb82475a0a452970618afb51a2d94'

893a2a5

Merge commit 'f4b01f079a6254b29ba02765b8fe15fa7669745d'

b295b40

Merge commit '966a65632255cfee649013fcfc9ddd687cae0311'

7122e30

Merge commit 'b7920de293a51139c1efed9bd591fd93edcc2f67'

1015191

Merge commit '2af08d2264b8f03cc01b62fde155807d049f1a76'

3f99563

Merge commit 'fa37af3df7a3b6a9656d6f9c0c1096515618c9c0'

36c487f

Merge commit 'a4cc5bfddec05aeb04615d7c6fa68eb073a71477'

fb241c8

Merge commit '75d940507bd7530b7e927537ff444874ef510546'

ee62eaa

Merge commit '152fb5056e523c08c8912341745c44efbcbf1bbe'

b7183a8

Merge commit 'd0782a47f31e628a1c1088d5256526d9e6819c98'

730229d

Merge commit '4af01fe82a318d538886c4a58d283f9b29f04b1f'

90222cd

Merge commit 'bf8fd5e1999983f1779c529cd0a065c2abcb8728'

84a7308

Merge commit 'fbee9e3def3c1ee576d1af85f3258cc816ceaaaf'

da83600

Merge commit '31d630598d3aa94e9779d958525cf1efdb0c8a11'

92f4af4

Merge commit '232b14c1e1da5be67214a4087e12648d4c05d48b'

9b21c84

Merge commit '688cdd10102b2865f118c6ceeba2ec7a36610b66'

fb76bbb

Merge commit 'e3d73512b1c3e0b5ebef824872fcbf68d4aaf265'

6e9c926

Merge commit '4091469786d22dec4bda83e9e14d91c6f1ab5b6f'

fca0fc5

Merge commit '63564ba68410c26d555fae333c564a829b2098cc'

00133e9

Merge commit '62a386fc1da99a1d77afb73e2ad19e7e47fd5a72'

cf178e7

Merge commit 'fc36f8fb64e523d3780b0ec7f91a4ee49d6034ff'

cfbc990

Merge commit 'a552753f9224e5f07e5a5ff917024f86df0d48ce'

51f7adb

Merge commit '673784335c74113b7518ec774e71b0fd086f9a89'

b41ea51

Merge commit '4603c46e13b77c75d00a4d79fb0e46ec57144623'

0a4d3a0

wangcj05 added the Ready To Review label Sep 26, 2023

Jimmy-INL commented Sep 28, 2023

View reviewed changes

Jimmy-INL and others added 3 commits September 28, 2023 12:29

modifying rquations 71,74,79

8c271cb

fix equation 71 and 74

1d33eaa

Merge branch 'newRep-Congjian' of github.com:Jimmy-INL/raven into new…

28ba71c

…Rep-Congjian

mandd reviewed Oct 13, 2023

View reviewed changes

wangcj05 added 4 commits October 16, 2023 21:04

address comments

5c29aec

delay import factory to allow definition

396dbc5

Merge branch 'devel' into newRep-Congjian

87cc738

revert changes

645644e

Merge branch 'newRep-Congjian' of github.com:Jimmy-INL/raven into new…

50fe87a

…Rep-Congjian

addressing Joshs comment of returning a different variable instead of…

6d7d77b

… modifying the input dataset

fix docs

548f9f7

wangcj05 removed the RAVENv3.0 label Apr 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New rep congjian #2058

New rep congjian #2058

Jimmy-INL commented Feb 7, 2023 •

edited by wangcj05

Loading

Jimmy-INL Sep 28, 2023

mandd left a comment

mandd Oct 13, 2023

wangcj05 Oct 17, 2023

mandd Oct 13, 2023

wangcj05 Oct 17, 2023

wangcj05 Oct 17, 2023

mandd Oct 13, 2023

wangcj05 Oct 17, 2023

wangcj05 Oct 17, 2023

wangcj05 commented Oct 17, 2023

moosebuild commented Oct 17, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

wangcj05 commented Nov 7, 2023

moosebuild commented Jan 3, 2024

wangcj05 commented Jan 3, 2024

moosebuild commented Jan 4, 2024

moosebuild commented Jan 4, 2024

moosebuild commented Jan 22, 2024

moosebuild commented Feb 29, 2024

moosebuild commented Mar 4, 2024

wangcj05 commented Mar 11, 2024

New rep congjian #2058

Are you sure you want to change the base?

New rep congjian #2058

Conversation

Jimmy-INL commented Feb 7, 2023 • edited by wangcj05 Loading

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

Implements the representativity theory through bias factors for validation purposes

For Change Control Board: Change Request Review

Choose a reason for hiding this comment

mandd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wangcj05 commented Oct 17, 2023

moosebuild commented Oct 17, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

moosebuild commented Nov 6, 2023

wangcj05 commented Nov 7, 2023

moosebuild commented Jan 3, 2024

wangcj05 commented Jan 3, 2024

moosebuild commented Jan 4, 2024

moosebuild commented Jan 4, 2024

moosebuild commented Jan 22, 2024

moosebuild commented Feb 29, 2024

moosebuild commented Mar 4, 2024

wangcj05 commented Mar 11, 2024

Jimmy-INL commented Feb 7, 2023 •

edited by wangcj05

Loading