Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amibiguity between sensor and MAS client device names #167

Closed
wants to merge 1 commit into from

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Sep 4, 2023

It fixes #156

But maybe they had the same name for a reason @GiulioRomualdi @lrapetti @traversaro ?

@Nicogene Nicogene added domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix labels Sep 4, 2023
@Nicogene Nicogene requested a review from traversaro September 4, 2023 12:37
@Nicogene Nicogene self-assigned this Sep 4, 2023
@traversaro
Copy link
Member

traversaro commented Sep 4, 2023

I think there are four main use cases of WBD:

  • UC1: WBD used internally in the same yarprobotinterface of the physical robot
  • UC2: WBD used internally of the simulated robot via gazebo_yarp_robotinterface plugin
  • UC3: WBD used externally via a separately launched yarprobotinterface that connects with the physical robot
  • UC4: WBD used externally via a separately launched yarprobotinterface that connects with the simulated robot

I originally wrote the file urdf/ergoCub/conf/estimators/wbd_ecub_sim.xml with device names choosen to easily support both UC2 and UC4, even if then we did not added any support for UC4 (that is tracked in #35). My final objective would be to be able to have a single wbd conf file to support all use cases, but that is another story. These PR introduces more different between UC2 and UC4, as it changes the names of client devices in UC4 to be different from the devices that provide the same sensors inside the gazebo_yarp_robotinterface plugin. Anyhow, this is not really relevant until we try to actually support UC4.

@Nicogene
Copy link
Member Author

Nicogene commented Sep 5, 2023

As discussed f2f w/ @traversaro, we agreed that it is fine at the end to have the mas client and the sensor w/ the same name, because it was handy if you need to use the same configuration for launching wbd internally.

Closing.

@Nicogene Nicogene closed this Sep 5, 2023
@Nicogene Nicogene deleted the fixWbdNames branch October 17, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software prj-ergocub Related to ErgoCub Project team-fix Related to Team Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change/Uniform names of YARP devices wrt WBD
2 participants