Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Sorting from Being Triggered When Using Filter Popovers with Keyboard Input #657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobigumo
Copy link

When using both sorting and filtering, the following issues occur when navigating with the keyboard:

  • Pressing Enter while focusing on the filter icon not only opens the popover but also triggers sorting.
  • Pressing Enter inside the input field within the popover also causes sorting to be triggered.

To prevent these issues, we stop the propagation of keydown events on the filter icon and within the PopoverDropdown.

Copy link

codesandbox bot commented Oct 18, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@tobigumo tobigumo force-pushed the fix/filter-popover-keyboard-sort-issue branch from 645c5bf to 61964b5 Compare October 18, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant