-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tvOS support #745
base: develop
Are you sure you want to change the base?
Add tvOS support #745
Conversation
sourceSets.matching { | ||
it.name == "tvosMain" | ||
}.configureEach { | ||
this.dependsOn(sourceSets.getByName("appleMain")) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to use
val appleSourceSets = listOf("watchos", "tvos")
val appleMainSourceSets = appleSourceSets.map { "${it}Main" }
val appleTestSourceSets = appleSourceSets.map { "${it}Test" }
sourceSets
.matching { it.name in appleMainSourceSets }
.configureEach { this.dependsOn(sourceSets.getByName("appleMain")) }
sourceSets
.matching { it.name in appleTestSourceSets }
.configureEach { this.dependsOn(sourceSets.getByName("appleTest")) }
you should up version in |
I have added the requested changes. Thank you for the suggestion, it helped with the error I had. So, basically I tried to follow the commits from PR #648 and added a tvOS target in the samples/kotlin-ios-app. TvOS app can be built without moko resources, but when I try to import mpp-library I’m getting the error:
I also tried creating a new tvOS application in the project, but I encountered the same error and couldn't figure out how to fix it. Would it be useful to add here the commits with the tvOS target in the existing app or the newly created app that I tried, even though it is not working properly? |
In this PR I've tried to add tvOS targets to
moko-resources
project.As mentioned in #739, the core implementation was already done in Apple generators, so I followed the approach in #648.
I've done the following:
I've tried to build the tvOS target in the sample ios app, but I'm getting the error
No matching variant of dev.icerock.moko:resources:0.24.1 was found.
Maybe you can suggest how I can test the tvOS target before it is added in the release version.