Fix compiler error in Swift UI helpers when not using moko-resources #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `StringDesc` protocol comes from projects that also incorporate moko-resources. For projects that use only moko-mvvm, this code was generating a compiler error: ``` ViewModelStateNullable.swift:99:60: Cannot find type 'StringDesc' in scope ``` Note that this particular helper didn't have a corresponding `state` version in `ViewModelState`. After this change, both `state` and `stateNullable` are consistent in terms of the methods they offer.
Alex009
requested changes
May 16, 2024
Comment on lines
-99
to
-105
| func stateNullable(_ flowKey: KeyPath<Self, CStateFlow<StringDesc>>) -> String? { | ||
| return stateNullable( | ||
| flowKey, | ||
| equals: { $0 === $1 }, | ||
| mapper: { $0?.localized() } | ||
| ) | ||
| } |
There was a problem hiding this comment.
it's should not be deleted. it's should be moved to mvvm-flow-resources
There was a problem hiding this comment.
No problem, I'll make that change.
There was a problem hiding this comment.
Hmm, there isn't a separate mvvm-flow-resources SwiftUI project (something like mokoMvvmFlowResourcesSwiftUI) to move this particular piece of code to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StringDescprotocol comes from projects that also incorporate moko-resources. For projects that use only moko-mvvm, this code was generating a compiler error:Note that this particular helper didn't have a corresponding
stateversion inViewModelState. After this change, bothstateandstateNullableare consistent in terms of the methods they offer.