Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failed to build for mac #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix failed to build for mac #11

wants to merge 1 commit into from

Conversation

nanangarsyad
Copy link

Tried to fix this issue
#10

ice1000
ice1000 requested changes Jun 11, 2020
View reviewed changes
Copy link
Owner

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need common/res/font?

swing/src/lie/mac.kt
import java.awt.event.KeyEvent

val ctrlOrMeta = if (SystemInfo.isMac) KeyEvent.META_DOWN_MASK else KeyEvent.CTRL_DOWN_MASK

object MacSpecific : AboutHandler, PreferencesHandler, QuitHandler {
object MacSpecific : AboutHandler, PreferencesHandler, QuitHandler {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this change

@ice1000
Copy link
Owner

ice1000 commented Jun 11, 2020

Good job, and btw your local git config doesn't match your github account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice1000 ice1000 ice1000 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nanangarsyad @ice1000