This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Dogfood QA Tools 3.0.0-alpha2 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Don't use generated Ant build file; our QA process is custom and too complex to ever want to offer using QA Tools configuration. This commit does try to stay as close as possible to the commands from the build file. * As QA Tools doesn't (yet?) support multiple test suites in PHPUnit, they are now organised by directory, rather than by suite. * As QA Tools doesn't (yet?) support a configured PHPUnit bootstrap file, it is passed to the binary using an option
added 2 commits
February 24, 2017 16:41
Mockery will soon no longer support its PHPUnit TestListener, neither is its configuration supported by QA Tools 3.0.0-alpha2.
rjd22
approved these changes
Mar 3, 2017
|
|
||
| abstract class ContainerTestCase extends TestCase | ||
| abstract class ContainerTestCase extends \Ibuildings\QaTools\Test\MockeryTestCase |
There was a problem hiding this comment.
Wow, you found one I missed 👏
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes the following changes:
Fixes #90
Mockery::close()for tests using Mockery