Added Server.php hooks for creating and updating CouchDB users #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lornajane
suggested changes
Apr 6, 2018
There was a problem hiding this comment.
I would LOVE to have this feature, thanks so much for the pull request! There are a couple of small things that are required though, hopefully you are still keen enough to make some changes (and if not that is fine too but please let me know in case anyone else wants to pick this up):
- first, the build failed on coding standards. I'm sorry this project should have a CONTRIBUTING file and I will add that, but for now the info you need is here https://github.com/ibm-watson-data-lab/php-couchdb#for-developers on how to run the tests and the codesniffer check
- the
@authortag isn't usually included at a per-method level (people will see your contribution through GitHub itself) - this feature needs a test. Take a look at the tests directory and let me know if you need more information than "please write a test". I'm happy to help but don't want to be patronising!
|
Just a quick ping to check if you're OK to pick up the comments above? If not, no worries. |
|
Sure, I'll loop around and revisit this in a few days. |
|
I have not yet written any tests... but at least the spacing and formatting issues are resolved. BTW, the build passed phpcs the first time, but not --standard=PSR-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to be able to create and update users on CouchDB in PHP7. Respectfully submitted.