Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user agent sniffing so touch events work on all mobile devices #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eligundry
Copy link

I saw that you were manually detecting iPod Touches and iPhones for the touch events, and, as a result, it wasn't working on my iPad or Android devices. So, I went ahead and removed those conditionals so it will work of all devices that support them.

@ARH-Digital
Copy link

Glad I found your fix eligundry. It has fixed the issue of not drawing on Android. +1

@gaucho1978
Copy link

yes it works on android, but if i zoom the webpage with a pinch, and then i draw, the line is not drawn under my finger, but in another location.

@gaucho1978
Copy link

some problems solved: gaucho1978@fe1c437

it is a bug related to offset() call that appears on chrome for android after a pinch.
I solved it.
I also allowed the ability to pinch and pan with 2 fingers and to draw with one finger.
i also made some other minor changes. see them all on the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants