os.path to pathlib.Path conversion #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates code to use pathlib.Path instead of os.path pathlib conversion fixup reference file is now a `pathlib.Path` object so don't need to prepend source folder. and need to etract file name for destination.
|
updated to fix issue #27. However, there are 3 tests that fail on my machine. The commit breaks one test: Two of the tests were failing before this commit: |
|
I found some more edits that need taking care of. So I've closed the pull request for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates code to use pathlib.Path instead of os.path
pathlib conversion fixup
reference file is now a
pathlib.Pathobject so don't needto prepend source folder. and need to etract file name for destination.