-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camel behaviour change #49
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # camel_test.go
I'm not sure which way is "more correct", so I'm just leaving this here for others to find and (for the more knowledgeable of you) to decide. |
I ran into this issue upgrading from eg:
|
I ran into the same problem. I can see arguments both ways for correctness. Maybe allow for a separate function for the old behavior or make this configuable? |
I ran into a similar issue. I’d argue that changing behaviour is bad, as it can have quite a few unintended side effects for other packages. How about adding a separate method for the ‘new’ behaviour instead? |
+1 on adding a separate method for the ‘new’ behavior |
I ran into a same issue, I think it is a BREAK CHANGE, maybe a new function to implement the new hehavior is better. |
+1 on this being a BREAKING CHANGE and should be in release notes |
Hi,
this PR is to show the behaviour change of ToCamel/ToLowerCamel as of 0.3.0. The testcase in 262f4c7 passes for 0.2.0 but fails with 0.3.0.