Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel behaviour change #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DavidS-ovm
Copy link

Hi,

this PR is to show the behaviour change of ToCamel/ToLowerCamel as of 0.3.0. The testcase in 262f4c7 passes for 0.2.0 but fails with 0.3.0.

@DavidS-ovm
Copy link
Author

I'm not sure which way is "more correct", so I'm just leaving this here for others to find and (for the more knowledgeable of you) to decide.

@skunkworker
Copy link

I ran into this issue upgrading from 0.2.0 to 0.3.0 where an already camelized string that had a custom acronym would suddenly become lowercased.

eg:

0.2.0

ToCamel("APIController") -> "APIController"

0.3.0

ToCamel("APIController") -> "ApiController"

@wagoodman
Copy link

I ran into the same problem. I can see arguments both ways for correctness. Maybe allow for a separate function for the old behavior or make this configuable?

@laknoll
Copy link

laknoll commented Oct 13, 2023

I ran into a similar issue. I’d argue that changing behaviour is bad, as it can have quite a few unintended side effects for other packages. How about adding a separate method for the ‘new’ behaviour instead?

@jazanne
Copy link

jazanne commented Oct 16, 2023

+1 on adding a separate method for the ‘new’ behavior

@keaising
Copy link

I ran into a same issue, I think it is a BREAK CHANGE, maybe a new function to implement the new hehavior is better.

@alelevinas
Copy link

+1 on this being a BREAKING CHANGE and should be in release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants