fix: VAL("invalid string") should return 0

fixes #71
ianatha · Nov 7, 2023 · 05fce63 · 05fce63
1 parent 941b275
commit 05fce63
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/libbababasic/src/main/java/io/atha/libbababasic/runtime/Functions.kt b/libbababasic/src/main/java/io/atha/libbababasic/runtime/Functions.kt
@@ -396,10 +396,7 @@ object Functions {
         try {
             result!!.float64 = str!!.toDouble()
         } catch (e: NumberFormatException) {
-            throw RuntimeError(
-                RuntimeError.ErrorCode.DATA_OUT_OF_RANGE,
-                "Failed to parse string: $str as numeric"
-            )
+            result!!.float64 = 0.0
         }
     }
 

diff --git a/libbababasic/src/test/kotlin/io/atha/libbababasic/IntegrationTest.kt b/libbababasic/src/test/kotlin/io/atha/libbababasic/IntegrationTest.kt
@@ -155,6 +155,11 @@ class IntegrationTest {
         runTest("string_functions.bas", "string_functions.bas.output")
     }
 
+    @Test
+    fun testValOfString() {
+        runTest("val_of_string.bas", "val_of_string.bas.output")
+    }
+
     @Test
     fun testJim01() {
         val e = assertFailsWith<RuntimeError> {

diff --git a/libbababasic/src/test/resources/val_of_string.bas b/libbababasic/src/test/resources/val_of_string.bas
@@ -0,0 +1,3 @@
+PRINT VAL("1")
+PRINT VAL("2")
+PRINT VAL("INVALID")
diff --git a/libbababasic/src/test/resources/val_of_string.bas.output b/libbababasic/src/test/resources/val_of_string.bas.output
@@ -0,0 +1,3 @@
+ 1.0 
+ 2.0 
+ 0.0