Rename extendType to extendedType and deprecate extendType #7372
+87
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixConcurrentQuery
…ixConcurrentQuery
soham-bentley
commented
Nov 14, 2024
| @@ -61,8 +61,12 @@ export interface QueryPropertyMetaData { | |||
| jsonName: string; | |||
| /** The name is the property's alias if the property is a generated one, otherwise, it is the name of the property. */ | |||
| name: string; | |||
| /** If this property is a PrimitiveECProperty, extend type is the extended type name of this property, if it is not defined locally will be inherited from base property if one exists, otherwise extended type is set to an empty string. */ | |||
| /** If this property is a PrimitiveECProperty, extend type is the extended type name of this property, if it is not defined locally will be inherited from base property if one exists, otherwise extend type is set to an empty string. | |||
| * @deprecated in 4.10 Use extendedType instead | |||
There was a problem hiding this comment.
I have written @deprecated in 4.10 Is the version number okay? Or should I write something else?
@khanaffan
There was a problem hiding this comment.
4.10 is already released. It'll have to go in 4.11
khanaffan
changed the title
khanaffan
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/iTwin/itwinjs-backlog/issues/1291