Deprecate UseJsPropertyNames and ECSqlStatement (which defaults to UseJsPropertyNames) #7315
+403
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanaffan
reviewed
Nov 4, 2024
| * - [Code Examples]($docs/learning/backend/ECSQLCodeExamples) illustrate the use of the iTwin.js API for executing and working with ECSQL | ||
| * @public | ||
| */ | ||
| export class ECSqlWriteStatement implements IDisposable { |
There was a problem hiding this comment.
So this is correct. I was more into ECDb.ExecuteNoneQueryECSql(ecql: string, args?: ECSqlBinder) Though I realize ECSqlBinder does not let you bind struct since its use in context of Query where we do not allow binding structs/arrays. So what you have here look fine. It requires less code change and can stay to the scope of ECDb.
|
@Mergifyio backport release/4.10.x |
🟠 Waiting for conditions to match
|
aruniverse
reviewed
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.