-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce vitest to core/quantity #7281
base: master
Are you sure you want to change the base?
Conversation
This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 |
…s/vitest-core-quantity
This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 |
can you edit the launch.json debug profile for running core quantity tests to be the same as core bentley and common |
This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 |
This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 |
done |
This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 |
My only feedback is that in some places you go from assert.strictEqual to vitest's toEqual, when technically they are slightly different including that strictEqual asserts the types are identical and toEqual doesn't (toStrictEqual would be the equivalent). If the tests pass I don't think this is worth changing though |
This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 |
This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏 |
Continuation of this effort: #7165