Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce vitest to core/quantity #7281

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

anmolshres98
Copy link
Contributor

Continuation of this effort: #7165

Copy link
Contributor

mergify bot commented Oct 19, 2024

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Copy link
Contributor

mergify bot commented Oct 20, 2024

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@hl662
Copy link
Contributor

hl662 commented Oct 21, 2024

can you edit the launch.json debug profile for running core quantity tests to be the same as core bentley and common

Copy link
Contributor

mergify bot commented Oct 22, 2024

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Copy link
Contributor

mergify bot commented Oct 23, 2024

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@anmolshres98
Copy link
Contributor Author

can you edit the launch.json debug profile for running core quantity tests to be the same as core bentley and common

done

@anmolshres98 anmolshres98 enabled auto-merge (squash) October 23, 2024 11:12
Copy link
Contributor

mergify bot commented Oct 23, 2024

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

@eringram
Copy link
Member

My only feedback is that in some places you go from assert.strictEqual to vitest's toEqual, when technically they are slightly different including that strictEqual asserts the types are identical and toEqual doesn't (toStrictEqual would be the equivalent). If the tests pass I don't think this is worth changing though

Copy link
Contributor

mergify bot commented Oct 30, 2024

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Copy link
Contributor

mergify bot commented Nov 9, 2024

This pull request is now in conflicts. Could you fix it @anmolshres98? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants