Make classIdsToClassNames explicit parameter independent of UseJsPropertyName #7264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanaffan
changed the title
khanaffan
changed the title
…plicit' into Soham/documenting_toRow_behaviour_all_flags_comb
…ffank/make-classid2classname-explicit
|
This pull request is now in conflicts. Could you fix it @khanaffan? 🙏 |
aruniverse
reviewed
Oct 21, 2024
rschili
approved these changes
Oct 22, 2024
|
does this need to be in a 4.9 patch? |
MichaelSwigerAtBentley
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior
UseJsPropertyNamealso implicitly meanClassIdToClassNamewastrue. But if explicitly specifiedClassIdToClassName: falsewe did not return classId(s) instead it will still return class names.New behavior
UseJsPropertyNamestill default toClassIdToClassName: trueunlessClassIdToClassName: falseis specified. If false was specified, then classId(s) are returned.Instance query when use with option
USE_JS_NAMEScontinue to returnUseJsPropertyName: true, ClassIdToClassName: true.@soham-bentley added new test for various permutations of
ECSqlRowFormat,classIdToClassNames&abbrivateBlob.imodel-native: iTwin/imodel-native#883