Check for the possibility that a TextureId is a number while cloning it. #6933
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should team responsible for Revit Connector be contacted and ask that they bring TextureIds over as hexadecimal strings? |
100%. It is never correct to store element IDs in JSON as numbers, JavaScript represents them as |
I will reach out to them with more details, i.e. iModel this was observed in |
pmconne
reviewed
Jul 3, 2024
| @@ -198,6 +198,10 @@ export class RenderMaterialElement extends DefinitionElement { | |||
| } | |||
| if (!Id64.isValid(sourceMap.TextureId) || sourceMap.TextureId === undefined) | |||
| continue; | |||
| // textureId has a chance to be a base 10 number instead of a hexadecimal string. This was observed in an iModel created with the Revit Connector. | |||
There was a problem hiding this comment.
This is going to cause problems in places other than onCloned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.