Append a test for schema with changes import without version increment #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is imported without version bump
rschili
previously approved these changes
Jul 2, 2024
|
/azp run iTwin.js |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rschili
approved these changes
Jul 19, 2024
imodeljs-admin
requested review from
a team,
aruniverse,
calebmshafer and
wgoehrig
as code owners
|
This pull request is now in conflicts. Could you fix it @6ar8nas? 🙏 |
nick4598
approved these changes
Jul 19, 2024
tcobbs-bentley
approved these changes
Jul 19, 2024
aruniverse
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imodel-native: iTwin/imodel-native#799
As per the referenced issue, when a schema is imported with new changes without a version increase, we should log an error to make sure the user is aware that the behavior is faulty. However, we do not want to throw an error to not break currently functional importSchemas workflows.
Closes iTwin/itwinjs-backlog#1101