Change ElementProps acquisition to getInstance #6549
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions for correctly linking your PRs. Don't include "PR", and I'm not sure if it's case-sensitive. |
|
/azp run iTwin.js |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bbastings
reviewed
May 24, 2024
Can you be more specific?
Have you measured this? |
bbastings
reviewed
May 24, 2024
|
Waiting for iTwin/imodel-native#782 to be completed before advancing further. |
|
Currently blocked by iTwin/itwinjs-backlog#1162 |
6ar8nas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we fetch ElementProps from the nativeDB. It allows bypassing the creation of a DgnElement on the native side and various json mapping adapters, which should result in both more accurate DB data representation and in some cases better Elements API performance (as explained in iTwin/imodel-native#782) by using InstanceReader for converting the data straight to an already parsed object.
To support this, a mapping function has been drafted that would allow all consuming applications to use the getInstance without the need to match the JSON representation to the accurate ElementProps extending interface.
Closes iTwin/itwinjs-backlog#1153