Improve Error Message for throwSqlError() #905
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRod1999
requested review from
pmconne,
khanaffan,
calebmshafer and
bbastings
as code owners
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
khanaffan
reviewed
Nov 1, 2024
khanaffan
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue
itwinjs-core: iTwin/itwinjs-core#7308
Currently the throwSqlError() function only gives "SQL Error", and only after enabling sql logs can we see a more useful error message. See issue for more details.
instead of using threSqlError() I used throwSqlResult() which when given a DBResult we can gather the error message from SQL. Also expand throwSqlResult() to provide the full sql log message.