Revert "Use the PulseAudio port name rather than the sink name (#419)" #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the port name is not as straighforward as changing the device description. Changing the device description is easy and supported in multiple modern media backends such as pipewire-media-session and Wireplumber. Also, the device description is unique most of the time in default deployments. The port name is often the same across different devices such as "Digital Output (S/PDIF)" or "Speakers". This leads to confusion when changing the output device via hotkeys and checking the active device via i3status in uncustomized i3status configurations. Furthermore, in pavucontrol, when assigning output/input devices, the port name does not show up, only the device description does. The port name is not used very often around interfacing with the audio backend as opposed to the device description, which is typically used in various places around third-party apps. This reverts commit 09358d2.
|
See also #480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the port name is not as straighforward as changing the device description.
Changing the device description is easy and supported in multiple modern media backends such as pipewire-media-session and Wireplumber.
Also, the device description is unique most of the time in default deployments. The port name is often the same across different devices such as "Digital Output (S/PDIF)" or "Speakers". This leads to confusion when changing the output device via hotkeys and checking the active device via i3status in uncustomized i3status configurations.
Furthermore, in pavucontrol, when assigning output/input devices, the port name does not show up, only the device description does. The port name is not used very often around interfacing with the audio backend as opposed to the device description, which is typically used in various places around third-party apps.
This reverts commit 09358d2.