Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: upgrade rsjf form to v5 #137

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: upgrade rsjf form to v5 #137

wants to merge 1 commit into from

Conversation

dmijatovic
Copy link
Collaborator

@dmijatovic dmijatovic commented Feb 20, 2024

WIP: work in progress. This upgrade is not complete. Additional work is required.

This draft PR describes first attempt to upgrade rsjf to v5. The following packages are upgraded:

  • @rjsf/bootstrap-4 to version 5.17.0
  • @rjsf/core to version 5.17.0
  • @rjsf/utils to version 5.17.0: this is new dependency. In v5 the utils and core are split in 2 dependencies
  • @rjsf/validator-ajv8 to version 5.17.0: this is new dependency. New validation package is created to include ajv8 validation library.
  • react-bootstrap to version 2

Next steps

The upgrade contains multiple breaking changes. Further improvements are required in order to have working solution. The area requiring further development are:

  • Validation. New validation package is introduced (@rjsf/validator-ajv8). The validation prop is required to be passed to Form component. Old validation approach is not compatible with v5. Additional improvements of the validation process are needed. The custom validation procedures should be implemented using new approach. One of the identified custom validation procedures that cannot be implemented using old approach is moleculeFormatValidators
  • Custom fields and widgets. New approach for custom widgets and fields is introduced. I tried to use new template approach with the old custom widgets and fields. Unfortunately, custom components do not work properly. As far as I can assess, the function signatures for the custom widgets and fields is changed. The parameters passed to the custom widgets are not correct and the widgets are not functioning properly. The widgets which are not functioning properly are:
    • Table widget: the table layout is not applied
    • ArrayFieldTemplate: this custom component breaks the solution with number of errors. It is clear that new parameters passed to the component are changed and that logic in the component cannot be applied properly

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for i-vresse-workflow-builder failed.

Name Link
🔨 Latest commit ff7e0b9
🔍 Latest deploy log https://app.netlify.com/sites/i-vresse-workflow-builder/deploys/65d4c335af36ec0008cd56ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant