fix: upvote election badges are not created by default

They are onoy created and assigned through upvote elections.

deploy_pangea_mainnet.sh

@@ -0,0 +1 @@
+cleos -u https://pangea.eosusa.io set contract dao.hypha build/dao dao_O3.wasm dao.abi

deploy_pangea_testnet.sh

@@ -0,0 +1 @@
+cleos -u https://test.pangea.eosusa.io set contract dao.hypha build/dao dao_O3.wasm dao.abi

include/badges/common.hpp

@@ -16,10 +16,12 @@ enum class SystemBadgeType
     Admin,
     Enroller,
     NorthStar,
-    Voter,
-    Delegate,
-    ChiefDelegate,
-    HeadDelegate,
+    // Upvote Election badges are system badges but they work differently from other badges
+    // These are only assigned through the upvote election process
+    Voter, // Upvote Election Voter 
+    Delegate, // Upvote Election Delegate
+    ChiefDelegate, // Upvote Election Chief Delegate
+    HeadDelegate, // Upvote Election Head Delegate
     None,
 };
 
@@ -33,6 +35,8 @@ namespace links {
     inline constexpr auto ADMIN_BADGE = eosio::name("adminbdg");
     inline constexpr auto ENROLLER_BADGE = eosio::name("enrollerbdg");
     inline constexpr auto NORTH_STAR_BADGE = eosio::name("northstarbdg");
+
+    // Upvote Election badges
     inline constexpr auto VOTER = eosio::name("voter");
     inline constexpr auto DELEGATE = eosio::name("delegate"); 
     inline constexpr auto HEAD_DELEGATE = eosio::name("headdelegate"); 

include/upvote_election/common.hpp

@@ -51,10 +51,6 @@ namespace links {
     inline constexpr auto UP_VOTE_VOTE = eosio::name("ue.vote");
     inline constexpr auto UPVOTE_GROUP_WINNER = eosio::name("ue.winner");
     inline constexpr auto VOTE = eosio::name("vote"); // ?? 
-
-    // these are defined in badges::common::links
-    // inline constexpr auto CHIEF_DELEGATE 
-    // inline constexpr auto HEAD_DELEGATE 
 }
 
 namespace items {

src/badges/badges.cpp

@@ -140,6 +140,12 @@ void onBadgeActivated(dao& dao, RecurringActivity& badgeAssign)
                 common::links::ENROLLER_BADGE
             );
         } break;
+
+        // Note:
+        // Upvote Election Badges should be a separate type since they 
+        // work differently from normal badges, e.g. nobody can apply 
+        // for these badges except through an upvote election...
+
         case SystemBadgeType::Voter: {
             createLink(badges_links::VOTER);
         } break;

src/dao.cpp

@@ -1400,9 +1400,6 @@ void dao::initSysBadges() {
 
   createSystemBadge(badges::common::links::ADMIN_BADGE, "Admin Badge", "https://assets.hypha.earth/badges/badge_admin.png");
   createSystemBadge(badges::common::links::ENROLLER_BADGE, "Enroller Badge", "https://assets.hypha.earth/badges/badge_enroller.png");
-  createSystemBadge(badges::common::links::DELEGATE, "Upvote Delegate Badge", "");
-  createSystemBadge(badges::common::links::CHIEF_DELEGATE, "Chief Delegate Badge", "");
-  createSystemBadge(badges::common::links::HEAD_DELEGATE, "Head Delegate Badge", "");
   createSystemBadge(badges::common::links::TREASURY_BADGE, "Treasurer Badge", "https://assets.hypha.earth/badges/badge_treasurer.png");
   createSystemBadge(badges::common::links::NORTH_STAR_BADGE, "North Star Badge", "https://assets.hypha.earth/badges/badge_north_star.png");
 
@@ -1419,12 +1416,6 @@ void dao::createSystemBadge(name badge_edge, string label, string icon) {
     systemBadgeType = badges::SystemBadgeType::NorthStar;
   } else if (badge_edge == badges::common::links::TREASURY_BADGE) {
     systemBadgeType = badges::SystemBadgeType::Treasurer;
-  } else if (badge_edge == badges::common::links::DELEGATE) {
-    systemBadgeType = badges::SystemBadgeType::Delegate;
-  } else if (badge_edge == badges::common::links::CHIEF_DELEGATE) {
-    systemBadgeType = badges::SystemBadgeType::ChiefDelegate;
-  } else if (badge_edge == badges::common::links::HEAD_DELEGATE) {
-    systemBadgeType = badges::SystemBadgeType::HeadDelegate;
   } else {
     eosio::check(false, "unknown system type");
   }