Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bruker XRF fix #326

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bruker XRF fix #326

wants to merge 3 commits into from

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Oct 22, 2024

Fix #323.

Progress of the PR

  • Don't raise error when the beam energy can't be found in bcf xrf files,
  • Add export_xml utility function,
  • update docstring (if appropriate),
  • update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • add tests,
  • ready for review.

Minimal example of the bug fix or the new feature

from rsciio.bruker import export_xml
export_xml("your_msa_file.msa")

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.81%. Comparing base (88923bf) to head (7926c57).

Files with missing lines Patch % Lines
rsciio/bruker/_api.py 63.15% 1 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   87.84%   87.81%   -0.03%     
==========================================
  Files          85       86       +1     
  Lines       11180    11198      +18     
  Branches     2280     2284       +4     
==========================================
+ Hits         9821     9834      +13     
- Misses        860      861       +1     
- Partials      499      503       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

self.hv = self.esma_metadata["PrimaryEnergy"]
self.hv = self.esma_metadata.get("PrimaryEnergy", None)
if self.hv is None:
_logger.warning("The beam energy couldn't be found.")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for a smaller file from #323 (comment).

@sem-geologist
Copy link
Contributor

Generally that Tornado instrument looks to me "Fascinating" as header clearly contains absolutely no information about primary energy of the beam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with loading Bruker .bcf and .spx files
2 participants