-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bruker XRF fix #326
base: main
Are you sure you want to change the base?
Bruker XRF fix #326
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 87.84% 87.81% -0.03%
==========================================
Files 85 86 +1
Lines 11180 11198 +18
Branches 2280 2284 +4
==========================================
+ Hits 9821 9834 +13
- Misses 860 861 +1
- Partials 499 503 +4 ☔ View full report in Codecov by Sentry. |
self.hv = self.esma_metadata["PrimaryEnergy"] | ||
self.hv = self.esma_metadata.get("PrimaryEnergy", None) | ||
if self.hv is None: | ||
_logger.warning("The beam energy couldn't be found.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for a smaller file from #323 (comment).
fb608d4
to
7926c57
Compare
Generally that Tornado instrument looks to me "Fascinating" as header clearly contains absolutely no information about primary energy of the beam. |
Fix #323.
Progress of the PR
export_xml
utility function,upcoming_changes
folder (seeupcoming_changes/README.rst
),docs/readthedocs.org:rosettasciio
build of this PR (link in github checks)Minimal example of the bug fix or the new feature