-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node model #19
Add node model #19
Conversation
|
||
public final String publicKey; | ||
|
||
public final int linkCount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is linkCount
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of peers, one of the values returned by nodeByAddr
How can the Java layer do stuff like Related: #18 |
I'm not sure if |
Actually, I don't even need |
You can read the private key from the config, but I'm not sure if it should be used for anything except cjdns. |
@kpcyrd See Step 4 of this. Can't think of another way to verify other than signing with the cjdns private key. |
I was busy and couldn't comment on this, yet. Sorry for that, I'll try to contribute in the next view days. |
@kpcyrd I will work on this branch when I get to the Node part after the Credentials. Thanks! |
Rebased and created branch in this repo so it's easier to work with. Closing this PR, k? See #34 |
I've added a mock NodeStore_nodeForAddr method which returns a new Object which is a bit closer to the admin api.
I don't know how to actually call this method, though.
The address gets generated from the public key later.
Feel free to commit on this branch.