feat: replace get and set methods with unified value option
#232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
smalluban
changed the title
get and set methods with unified value optionget and set methods with unified value option
smalluban
force-pushed
the
main
branch
4 times, most recently
from
9f1a7a9
to
50e3793
Compare
smalluban
force-pushed
the
feat-value-over-get-set
branch
from
e9bf5f5
to
d2174b7
Compare
smalluban
force-pushed
the
feat-value-over-get-set
branch
from
d2174b7
to
5db127b
Compare
smalluban
force-pushed
the
main
branch
2 times, most recently
from
7c76f82
to
faec4c6
Compare
BREAKING CHANGE: `get` and `set` methods must be replaced with `value` option. Properties no longer reflect value to the corresponding attribute by default. New `reflect` option must be set to `true`.
smalluban
force-pushed
the
feat-value-over-get-set
branch
from
f5b3d65
to
b04e2af
Compare
smalluban
force-pushed
the
feat-value-over-get-set
branch
from
a2b3a34
to
07e4f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
getandsetmethods are replaced withvalueoptionreflectoption must be used