fix(cache): clean up not reachable removal of deps

hybridsjs · Dec 7, 2023 · c1cb4f7 · c1cb4f7
1 parent a52bf00
commit c1cb4f7
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/src/cache.js b/src/cache.js
@@ -152,12 +152,6 @@ function deleteEntry(entry) {
     setTimeout(() => {
       for (const e of gc) {
         if (!e.contexts || e.contexts.size === 0) {
-          if (e.deps) {
-            for (const depEntry of e.deps) {
-              depEntry.contexts.delete(e);
-            }
-          }
-
           const targetMap = entries.get(e.target);
           targetMap.delete(e.key);
         }

diff --git a/test/spec/cache.js b/test/spec/cache.js
@@ -7,7 +7,7 @@ import {
   observe,
 } from "../../src/cache.js";
 
-import { resolveRaf } from "../helpers.js";
+import { resolveRaf, resolveTimeout } from "../helpers.js";
 
 describe("cache:", () => {
   let target;
@@ -166,6 +166,20 @@ describe("cache:", () => {
 
       expect(spy).toHaveBeenCalledTimes(0);
     });
+
+    it("deletes entry if it has no contexts", () => {
+      get(target, "key", () =>
+        get(target, "otherKey", () => get(target, "deepKey", () => "value")),
+      );
+      invalidate(target, "otherKey", { deleteEntry: true });
+
+      return resolveTimeout(() => {
+        expect(getEntries(target).map(({ key }) => key)).toEqual([
+          "key",
+          "deepKey",
+        ]);
+      });
+    });
   });
 
   describe("invalidateAll()", () => {