-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rubicon #356
Open
etherealiska
wants to merge
14
commits into
hummingbot:development
Choose a base branch
from
RubiconDeFi:feat/rubicon
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/rubicon #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync / gateway staging -> master for Hummingbot gateway version 2.0.0
sync / gateway development -> staging
fix/ adding uniswap updates PR to gateway staging
…ion-to-2.0.1 Fix gw staging version to 2.0.1
sync / gateway staging -> master for Hummingbot gateway version 2.0.1
* Scaffolding * Add rubicon configs * Add base and arb sepolia tokens * sepolia tokens * Add rubicon to connectors * Add rubicon to valid spender list * Working gateway * ensure pk is set to sign orders * url typo * calculate markets dynamically * Add keys to config * Add fake private key * Calculate slippage into output amount * Use gateway to get wallet * No decaying orders * Networks must be lowercased * Return empty ticker if there is no subgraph for trades * Tests * Fixed unit tests
2 tasks
hi @etherealiska, PR should be pointed to development branch |
Closed
@etherealiska ill be moving this task to on hold until PR is updated to latest development |
hi @etherealiska Please resolve all the conflicts and update branch to latest development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This is the main pr for Rubicon gateway. The functionality of this connector can be accessed through the endpoints on the clob routes combined with the endpoints on the network routes.
Tests performed by the developer:
All unit tests are passing, and manually tested with hummingbots pure MM strategy.