did the same for other queries as well

huggle · Dec 23, 2014 · d9ef73b · d9ef73b
1 parent cff8c07
commit d9ef73b
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 3 deletions.
diff --git a/huggle/apiquery.cpp b/huggle/apiquery.cpp
@@ -250,6 +250,13 @@ void ApiQuery::Process()
 
 void ApiQuery::ReadData()
 {
+    // don't even try to do anything if query was killed
+    if (this->Status == StatusKilled)
+        return;
+    if (this->Result == nullptr)
+        throw new Huggle::NullPointerException("loc ApiQuery::Result", BOOST_CURRENT_FUNCTION);
+    if (this->reply == nullptr)
+        throw new Huggle::NullPointerException("loc ApiQuery::reply", BOOST_CURRENT_FUNCTION);
     this->Result->Data += QString(this->reply->readAll());
 }
 

diff --git a/huggle/webserverquery.cpp b/huggle/webserverquery.cpp
@@ -9,6 +9,7 @@
 //GNU General Public License for more details.
 
 #include "webserverquery.hpp"
+#include "exception.hpp"
 #include <QtNetwork>
 #include <QUrl>
 #include <QtXml>
@@ -24,6 +25,17 @@ WebserverQuery::WebserverQuery()
     this->UsingPOST = false;
 }
 
+Huggle::WebserverQuery::~WebserverQuery()
+{
+    if (this->reply != nullptr)
+    {
+        this->reply->abort();
+        this->reply->disconnect(this);
+        this->reply->deleteLater();
+        this->reply = nullptr;
+    }
+}
+
 void WebserverQuery::Process()
 {
     if (this->URL == "")
@@ -61,12 +73,25 @@ void WebserverQuery::Kill()
 }
 
 void WebserverQuery::ReadData()
-{
+{    // don't even try to do anything if query was killed
+    if (this->Status == StatusKilled)
+        return;
+    if (this->Result == nullptr)
+        throw new Huggle::NullPointerException("loc WebserverQuery::Result", BOOST_CURRENT_FUNCTION);
+    if (this->reply == nullptr)
+        throw new Huggle::NullPointerException("loc WebserverQuery::reply", BOOST_CURRENT_FUNCTION);
     this->Result->Data += QString(this->reply->readAll());
 }
 
 void WebserverQuery::Finished()
 {
+    // don't even try to do anything if query was killed
+    if (this->Status == StatusKilled)
+        return;
+    if (this->Result == nullptr)
+        throw new Huggle::NullPointerException("loc WebserverQuery::Result", BOOST_CURRENT_FUNCTION);
+    if (this->reply == nullptr)
+        throw new Huggle::NullPointerException("loc WebserverQuery::reply", BOOST_CURRENT_FUNCTION);
     this->Result->Data += QString(this->reply->readAll());
     // now we need to check if request was successful or not
     if (this->reply->error())

diff --git a/huggle/webserverquery.hpp b/huggle/webserverquery.hpp
@@ -28,6 +28,7 @@ namespace Huggle
             Q_OBJECT
         public:
             WebserverQuery();
+            ~WebserverQuery();
             //! Whether the query will submit parameters using POST data
             bool UsingPOST;
             //! This is an url of api request, you probably don't want to change it unless

diff --git a/huggle/wlquery.cpp b/huggle/wlquery.cpp
@@ -27,8 +27,13 @@ WLQuery::WLQuery(WikiSite *site)
 
 WLQuery::~WLQuery()
 {
-    delete Result;
-    this->Result = nullptr;
+    if (this->networkReply != nullptr)
+    {
+        this->networkReply->abort();
+        this->networkReply->disconnect(this);
+        this->networkReply->deleteLater();
+        this->networkReply = nullptr;
+    }
 }
 
 QString WLQuery::QueryTypeToString()