fixed missing references to site, disabled constructor that allowed that

huggle · Oct 19, 2017 · 11fcf6c · 11fcf6c
1 parent 3974607
commit 11fcf6c
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 14 deletions.
diff --git a/huggle/apiquery.cpp b/huggle/apiquery.cpp
@@ -29,13 +29,6 @@ ApiQuery::ApiQuery()
     this->Type = QueryApi;
 }
 
-ApiQuery::ApiQuery(Action action)
-{
-    this->RequestFormat = XML;
-    this->Type = QueryApi;
-    this->SetAction(action);
-}
-
 ApiQuery::ApiQuery(Action action, WikiSite *site)
 {
     this->RequestFormat = XML;

diff --git a/huggle/apiquery.hpp b/huggle/apiquery.hpp
@@ -72,7 +72,6 @@ namespace Huggle
         public:
             //! Creates a new instance of this class and set the defaults
             explicit ApiQuery();
-            explicit ApiQuery(Action action);
             explicit ApiQuery(Action action, WikiSite *site);
             ~ApiQuery();
             Action GetAction();

diff --git a/huggle/extension_list/extension-thanks b/huggle/extension_list/extension-thanks
diff --git a/huggle/login.cpp b/huggle/login.cpp
@@ -608,7 +608,7 @@ bool Login::RetrieveGlobalConfig()
     }
     this->loadingForm->ModifyIcon(this->GlobalRow, LoadingForm_Icon_Loading);
     this->Update(_l("[[login-progress-global]]"));
-    this->qConfig = new ApiQuery(ActionQuery);
+    this->qConfig = new ApiQuery(ActionQuery, nullptr);
     this->qConfig->OverrideWiki = hcfg->GlobalConfigurationWikiAddress;
     this->qConfig->Parameters = "prop=revisions&rvprop=content&rvlimit=1&titles=" + hcfg->SystemConfig_GlobalConfigYAML;
     this->qConfig->Process();
@@ -1413,7 +1413,7 @@ void Login::OnTimerTick()
 void Login::on_pushButton_clicked()
 {
     this->Disable();
-    this->qDatabase = new ApiQuery(ActionQuery);
+    this->qDatabase = new ApiQuery(ActionQuery, nullptr);
     this->Refreshing = true;
     hcfg->SystemConfig_UsingSSL = this->ui->checkBox->isChecked();
     this->timer->start(HUGGLE_TIMER);

diff --git a/huggle/reloginform.cpp b/huggle/reloginform.cpp
@@ -154,7 +154,7 @@ void ReloginForm::LittleTick()
             return;
         }
         QString token = login_->GetAttribute("token");
-        this->qReloginPw = new ApiQuery(ActionLogin);
+        this->qReloginPw = new ApiQuery(ActionLogin, nullptr);
         this->qReloginPw->HiddenQuery = true;
         this->qReloginPw->Parameters = "lgname=" + QUrl::toPercentEncoding(Configuration::HuggleConfiguration->SystemConfig_Username)
             + "&lgpassword=" + QUrl::toPercentEncoding(this->ui->lineEdit->text()) + "&lgtoken=" + QUrl::toPercentEncoding(token);

diff --git a/huggle/requestprotect.cpp b/huggle/requestprotect.cpp
@@ -142,7 +142,7 @@ void RequestProtect::Tick()
 
 void Huggle::RequestProtect::on_pushButton_clicked()
 {
-    this->qRFPPage = new ApiQuery(ActionQuery);
+    this->qRFPPage = new ApiQuery(ActionQuery, this->page->GetSite());
     // if this wiki has the requests in separate section, get it, if not, we get a whole page
     if (this->page->GetSite()->GetProjectConfig()->RFPP_Section == 0)
     {

diff --git a/huggle/revertquery.cpp b/huggle/revertquery.cpp
@@ -684,7 +684,7 @@ bool RevertQuery::ProcessRevert()
     }
     this->CustomStatus = "Retrieving content of previous version";
     // now we need to get the content of page
-    this->qRetrieve = new ApiQuery(ActionQuery);
+    this->qRetrieve = new ApiQuery(ActionQuery, this->GetSite());
     this->qRetrieve->Parameters = "prop=revisions&revids=" + QString::number(this->SR_RevID) + "&rvprop=" +
                                   QUrl::toPercentEncoding("ids|content");
     this->qRetrieve->Process();