Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve image-to-image task page #867

Merged
merged 40 commits into from
Sep 3, 2024

Conversation

linoytsaban
Copy link
Contributor

@linoytsaban linoytsaban commented Aug 26, 2024

some changes to improve clarity of task description, and general updates to improve task page

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for this PR, thanks a lot @linoytsaban! But the inference examples in the task page are using diffusion text-to-image and not super-resolution or colorization per se.

I wonder if we could add something else to the description, in the lines of "It can also be used in text-to-image tasks to provide a visual guidance during the generation process."

And/or, we could use some super-resolution example as well.

packages/tasks/src/tasks/image-to-image/data.ts Outdated Show resolved Hide resolved
@linoytsaban
Copy link
Contributor Author

linoytsaban commented Aug 26, 2024

@pcuenca that's a good point, thanks! I think doing both - adding additional inference examples + a sentence about the relation to text-to-image task - will be the best, so we show "pure" image-to-image and also how it can be used for added control in text-to-image. I'll add to this PR :)

@linoytsaban linoytsaban changed the title minor change to image-to-image task description improve image-to-image task page Aug 27, 2024
@linoytsaban
Copy link
Contributor Author

linoytsaban commented Aug 27, 2024

@pcuenca wdyt of the added demo & doc links for the img2img use cases? I still need to add another proper inference example for style transfer, but I thought It might be nice to have some like that

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this! <3

packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-to-image/data.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small comments, looks good to me otherwise!!! <3

packages/tasks/src/tasks/image-to-image/data.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Feel free to merge once you feel it's ready

Comment on lines 29 to 32
pipeline.enable_model_cpu_offload()
# remove following line if xFormers is not installed or you have PyTorch 2.0 or higher installed
pipeline.enable_xformers_memory_efficient_attention()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that our audience for task pages is more introductory, so this might be too advanced for them

packages/tasks/src/tasks/image-to-image/about.md Outdated Show resolved Hide resolved
@linoytsaban linoytsaban merged commit e0d6c95 into huggingface:main Sep 3, 2024
2 of 4 checks passed
@linoytsaban linoytsaban deleted the img2img-task branch September 3, 2024 06:54
@pcuenca
Copy link
Member

pcuenca commented Sep 3, 2024

🚀

@julien-c
Copy link
Member

julien-c commented Sep 3, 2024

nice update @linoytsaban!

@julien-c
Copy link
Member

julien-c commented Sep 3, 2024

should one create a new @huggingface/tasks release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants