Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2080ti, 2080 into hardware.ts #853

Merged
merged 4 commits into from
Aug 23, 2024
Merged

add 2080ti, 2080 into hardware.ts #853

merged 4 commits into from
Aug 23, 2024

Conversation

thien
Copy link
Contributor

@thien thien commented Aug 16, 2024

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 🤗

Will wait for @pcuenca to give this an LGTM too - since he verified the numbers for other hardware on the list too!

@pcuenca
Copy link
Member

pcuenca commented Aug 23, 2024

Thanks for updating @Vaibhavs10! Fixing the lint and merging!

@pcuenca
Copy link
Member

pcuenca commented Aug 23, 2024

Thanks a lot @thien 🙌 My first GPU was a 2080 Ti in 2018, I still use it :)

@pcuenca pcuenca merged commit 207340f into huggingface:main Aug 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants