Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade prettier and move deps to devDeps #355

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Upgrade prettier and move deps to devDeps #355

merged 3 commits into from
Nov 24, 2023

Conversation

mishig25
Copy link
Collaborator

@mishig25 mishig25 commented Nov 24, 2023 •
edited
Loading

Follow up to #297 & #317 (comment)

  1. Moved deps to devDeps (cc: @coyotte508 please check)
  2. Prettier was not running on svelte files. Upgrading prettier fixed the issue

@mishig25 mishig25 marked this pull request as ready for review November 24, 2023 10:12
@mishig25 mishig25 changed the title Upgrade prettier and mode deps to DevDeps Upgrade prettier and move deps to DevDeps Nov 24, 2023
@mishig25 mishig25 changed the title Upgrade prettier and move deps to DevDeps Upgrade prettier and move deps to devDeps Nov 24, 2023
coyotte508
coyotte508 approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Deps or dev deps shouldn't matter, since it's the root package;json and is not meant to be published

@mishig25 mishig25 merged commit 04d8c4f into main Nov 24, 2023
1 check passed
@mishig25 mishig25 deleted the edit_package.json branch November 24, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coyotte508 coyotte508 coyotte508 approved these changes

@julien-c julien-c Awaiting requested review from julien-c

@osanseviero osanseviero Awaiting requested review from osanseviero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishig25 @coyotte508