-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Languages subpackage #292
Languages subpackage #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some changes @julien-c , let me know what you think
- Split into multiple files so that github lets us review non-data files
- add tests
- add a README.md
I also created a language(code)
function & changed the arg of wikiLink
to just be the language code
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
splitting files + tests is great I will still need the dicts exported (i need them in the moon codebase) and also merged in a single dict So personnally i'd remvoe the |
packages/languages/src/language.ts
Outdated
export function language(code: keyof typeof LANGUAGES_ISO_639_1): Language; | ||
export function language(code: keyof typeof LANGUAGES_ISO_639_3): Language; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably hard to compute for tsc
This reverts commit 49dc263.
No description provided.