Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages subpackage #292

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Languages subpackage #292

merged 18 commits into from
Nov 10, 2023

Conversation

julien-c
Copy link
Member

No description provided.

Copy link
Member

@coyotte508 coyotte508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some changes @julien-c , let me know what you think

  • Split into multiple files so that github lets us review non-data files
  • add tests
  • add a README.md

I also created a language(code) function & changed the arg of wikiLink to just be the language code

packages/languages/src/types.d.ts Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

README.md Show resolved Hide resolved
@julien-c
Copy link
Member Author

I did some changes @julien-c , let me know what you think

  • Split into multiple files so that github lets us review non-data files
  • add tests
  • add a README.md

I also created a language(code) function & changed the arg of wikiLink to just be the language code

splitting files + tests is great

I will still need the dicts exported (i need them in the moon codebase) and also merged in a single dict

So personnally i'd remvoe the language function which does not bring anythign to my use case, but up to you if you want to keep it

Comment on lines 8 to 9
export function language(code: keyof typeof LANGUAGES_ISO_639_1): Language;
export function language(code: keyof typeof LANGUAGES_ISO_639_3): Language;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably hard to compute for tsc

@julien-c julien-c merged commit 3daedd7 into main Nov 10, 2023
2 checks passed
@julien-c julien-c deleted the languages-subpackage branch November 10, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants