[Core] be more specific when doing accelerate imports. #8772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
reviewed
Jul 2, 2024
| @@ -83,9 +83,9 @@ def run(self) -> dict: | |||
|
|
|||
| accelerate_version = "not installed" | |||
| if is_accelerate_available(): | |||
| import accelerate | |||
| from accelerate import __version__ | |||
There was a problem hiding this comment.
This doesn't actually speed things up, see my trace here from accelerate:
Before:
After:
| @@ -72,7 +72,7 @@ | |||
|
|
|||
|
|
|||
| if is_accelerate_available(): | |||
| import accelerate | |||
| from accelerate import init_empty_weights, load_checkpoint_and_dispatch | |||
|
@muellerzr just making sure that all of your findings are from |
|
@sayakpaul yep! |
|
So if you want to support older versions/worry about that, definitely feel free to do so. :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
IMO it's better to rely on a stable version of |
|
Agreed, |
|
@muellerzr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
By being more specific on the imports, we can cut down the overall import time in our library.
Follow this thread: https://huggingface.slack.com/archives/C021H1P1HKR/p1719924173632779.
We should try to identify more such opportunities.