Optimize WCond and ReduceIndex implementations for improved performance and safety #2648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces some optimizations to the
WCond
andReduceIndex
structs to enhance performance and improve code clarity.Key Changes:
WCond
:ReduceIndex
:Clone
bounds sinceT: Copy
andU: Copy
implicitly includeClone
.iter_mut().enumerate()
withfor i in 0..dst_len
loops to reduce iterator overhead and improve loop performance.dst_ptr = dst.spare_capacity_mut().as_mut_ptr()
and used thewrite
method to directly insert data. This approach is more explicit and avoids unnecessary type conversions.Next Steps:
Regards,
Zijing