Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new template 'lightweight-thymus' #112

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

sooheelee
Copy link

No description provided.

@sooheelee sooheelee marked this pull request as ready for review November 20, 2024 13:39
@sooheelee
Copy link
Author

Hi @jpuerto-psc @gesinaphillips and @lchoy. I have added a workspace template that represents my recent HuBMAP Hackathon (winning) submission. The template actually pulls the main analysis jupyter notebook and some small text files from https://github.com/sooheelee/notebooks/tree/main/hubmap-hackathon-2024. May I please get a review?

@sooheelee sooheelee changed the title Create new template folder and add render.py Add new template 'lightweight-thymus' Nov 20, 2024
@thomcsmits
Copy link
Collaborator

@sooheelee Can we, instead of copying over a notebook from another github repo, use that notebook directly here as a template? This gives us more stability, such that that notebook doesn't suddenly change.

@sooheelee
Copy link
Author

Hi @thomcsmits. That is certainly possible and I can change things to consolidate to one notebook. I do want to point out the risk of my repo notebook changing is nil as (i) I created the project specifically for its use in HuBMAP workspaces and (ii) I am a paying github user.

Switch out template to main analysis notebook instead of abbreviated one that pulls the analysis notebook from another repo.
@sooheelee
Copy link
Author

@thomcsmits, the switched out notebook is now available for your review. Thank you.

@thomcsmits
Copy link
Collaborator

@sooheelee I think the convert-notebook.py got some unexpected format when you ran it. Because of this, I am not able to reverse it and open this as a notebook. Can you add the .ipynb file to this PR? (Or send it to me on slack / email) Thanks!

@sooheelee
Copy link
Author

@sooheelee
Copy link
Author

Hi @thomcsmits, wondering if you are set for the review or if I can clarify/add anything more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants