Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John conroy/publication page #3042

Merged
merged 4 commits into from
Mar 21, 2023
Merged

John conroy/publication page #3042

merged 4 commits into from
Mar 21, 2023

Conversation

john-conroy
Copy link
Collaborator

@john-conroy john-conroy commented Mar 14, 2023

Towards #3035. Add starter for publication detail page.

Screen Shot 2023-03-21 at 2 35 10 PM

john-conroy and others added 4 commits March 14, 2023 14:15
* Move summary title to own component

* Add util to get combined dataset status

* Add basic publication page summary

* Pull repeated array into variable

* Replace hubmap id with title prop in summary

* Add title for publication summary

* John conroy/publication related data (#3046)

* Make derived entities tabs more flexible to entities

* Change derived entities section header for reuse with publications data

* Make derived entities tabs accept warning message fn as prop

* Pass aria label as props to tabs

* Rename derived entities tabs to related entities tabs

* Rename derived entities section wrapper

* Add related entities table component

* Add shared columns file

* Add entity type to derived entity hooks

* Update entities table to take header and body rows as props

* Use related entities table in derived table components

* Fix import

* Add hook to fetch ancestors

* Add publication entities tabs

* Pass columns to tabs

* Add donors and define columns for publication entities

* Consolidate hooks

* Consolidate derived entities hooks

* Move hooks from page inside derived datasets

* Update prop name

* Update entities table story

* Use tabs in derived datasets section and remove unused table components

* Move hooks for derived inside component

* Fix formatting issues

* Add changelog

---------

Co-authored-by: John Conroy <[email protected]>

---------

Co-authored-by: John Conroy <[email protected]>
@john-conroy john-conroy marked this pull request as ready for review March 21, 2023 18:34
@john-conroy john-conroy merged commit 16cd780 into main Mar 21, 2023
@john-conroy john-conroy deleted the john-conroy/publication-page branch March 21, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant