Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GitHub notification interface return "Unable to parse If-Modified… #1984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AsherSu
Copy link

@AsherSu AsherSu commented Nov 12, 2024

…-Since request header"

Description

fix GitHub notification interface return "Unable to parse If-Modified-Since request header" (fix #1985)

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.07%. Comparing base (e4ef482) to head (11c65f4).

Files with missing lines Patch % Lines
.../java/org/kohsuke/github/GHNotificationStream.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1984      +/-   ##
============================================
- Coverage     83.10%   83.07%   -0.03%     
  Complexity     2331     2331              
============================================
  Files           231      231              
  Lines          7172     7173       +1     
  Branches        378      379       +1     
============================================
- Hits           5960     5959       -1     
- Misses          974      975       +1     
- Partials        238      239       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/notifications interface return "Unable to parse If-Modified-Since request header"
1 participant