Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test zero byte after hyphen in comment #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hsivonen
Copy link
Member

@hsivonen hsivonen commented Aug 5, 2020

No description provided.

@hsivonen hsivonen requested a review from jgraham August 5, 2020 10:43
"output":[["Comment", "-\uFFFD"]],
"errors":[
{ "code": "incorrectly-opened-comment", "line": 1, "col": 4 },
{ "code": "unexpected-null-character", "line": 1, "col": 4 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column indices are zero-based, so it should be column 3 here and in the error above.

"errors":[
{ "code": "incorrectly-opened-comment", "line": 1, "col": 4 },
{ "code": "unexpected-null-character", "line": 1, "col": 4 },
{ "code": "eof-in-comment", "line": 1, "col": 5 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ends up in the bogus comment state which doesn't error on EOF: https://html.spec.whatwg.org/multipage/parsing.html#bogus-comment-state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants