This repository has been archived by the owner on Apr 15, 2018. It is now read-only.
Propagate extension failures to user-space (refs #171) #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I will take a look soon, but not before next week. Apologies for the delay. |
|
No problem at all, we will proceed our experimentation with a local version of our own for the time being. I will also proceed with dealing with the rest of the issues and making the corresponding pull requests so that, hopefully, when you get the time you will have the chance to review them all at once. Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #171 I have removed the actor-system stopping behavior, modernized the
ConstructrExtensionby switching to the new style of extension implementation and added the ability to hook up event handlers to ConstructR failures, for which I added a couple of tests as well. In the context of this work I also removed the deprecatedActorDSLstuff from the multi-jvm test and replaced it with regular actor creation code, as per akka guidelines.