adapt to calculator #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsd-dev
reviewed
Nov 24, 2020
| @@ -40,6 +37,9 @@ def _run(self): | |||
| self._rate.sleep() | |||
|
|
|||
| def start(self): | |||
| self._pub_diag = rospy.Publisher( | |||
| '/diagnostics', DiagnosticArray, queue_size=10 | |||
There was a problem hiding this comment.
Shouldn't you be using output_topic_name and msg_type here?
There was a problem hiding this comment.
I rewrite this function in my code.
There was a problem hiding this comment.
self._pub_diag = rospy.Publisher(
'/diagnostics', DiagnosticArray, queue_size=10
Should be
self._pub_diag = rospy.Publisher(
output_topic_name, msg_type, queue_size=10
isn't it?
|
Have you made any changes in monitor.py? It looks similar to the existing monitor script. |
|
I didn't change any in monitor.py. I just rewrite some functions in my code. |
Then can you remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a calculator ros package. But I need to modify a little bit of this package.
It seems that this package is still functional. But please check it again.