Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added customizable user data to Callback #97

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bakadave
Copy link

@bakadave bakadave commented Nov 2, 2023

I wanted to have multiple clients calling the same callback function but have access to different data members. Should be a pretty minimal change. I guess it will be a breaking change. If the interest is there I'm sure it can be solved with a few overloads.

P.S.: This is my first ever PR, hope I did okay.

@bakadave bakadave marked this pull request as draft November 2, 2023 14:56
@bakadave
Copy link
Author

@hsaturn how do you suggest I proceed? My version works well for me, I'd love for it to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant